<html>
<head><meta charset="utf-8"><title>borrowck-feature-nll-overrides-migrate test is wrong? · t-compiler · Zulip Chat Archive</title></head>
<h2>Stream: <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/index.html">t-compiler</a></h2>
<h3>Topic: <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/borrowck-feature-nll-overrides-migrate.20test.20is.20wrong.3F.html">borrowck-feature-nll-overrides-migrate test is wrong?</a></h3>

<hr>

<base href="https://rust-lang.zulipchat.com">

<head><link href="https://rust-lang.github.io/zulip_archive/style.css" rel="stylesheet"></head>

<a name="148327010"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/borrowck-feature-nll-overrides-migrate%20test%20is%20wrong%3F/near/148327010" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nagisa <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/borrowck-feature-nll-overrides-migrate.20test.20is.20wrong.3F.html#148327010">(Nov 25 2018 at 18:08)</a>:</h4>
<p>src/test/ui/borrowck/borrowck-feature-nll-overrides-migrate.rs test has a few revision-like comments, but there is a mistake: its compile-flags and edition are not taken into account because revision like attributes/flags cannot have a space between <code>//</code> and <code>[</code>. cc <span class="user-mention" data-user-id="116083">@pnkfelix</span></p>



<a name="148375455"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/borrowck-feature-nll-overrides-migrate%20test%20is%20wrong%3F/near/148375455" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/borrowck-feature-nll-overrides-migrate.20test.20is.20wrong.3F.html#148375455">(Nov 26 2018 at 15:42)</a>:</h4>
<p>we still have some ways to go towards making the unit test system robust :/</p>



<a name="148375462"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/borrowck-feature-nll-overrides-migrate%20test%20is%20wrong%3F/near/148375462" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/borrowck-feature-nll-overrides-migrate.20test.20is.20wrong.3F.html#148375462">(Nov 26 2018 at 15:42)</a>:</h4>
<p>I'd like to see the <code>//~ ERROR</code> lines mandatory, too</p>



<a name="148633697"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/borrowck-feature-nll-overrides-migrate%20test%20is%20wrong%3F/near/148633697" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/borrowck-feature-nll-overrides-migrate.20test.20is.20wrong.3F.html#148633697">(Nov 27 2018 at 12:04)</a>:</h4>
<p>I think there was general agreement that we should just do that, i.e. make the lines mandatory (for <code>//~ ERROR</code>, at least. I cannot remember what was decided about <code>//~ WARN</code>). It might also be good to have <code>compiletest</code> error on potential typos using a regexp like <code>//[ ]+\[.+\]~</code> or something</p>



<a name="148633782"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/borrowck-feature-nll-overrides-migrate%20test%20is%20wrong%3F/near/148633782" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> oli <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/borrowck-feature-nll-overrides-migrate.20test.20is.20wrong.3F.html#148633782">(Nov 27 2018 at 12:06)</a>:</h4>
<p>state of the system is that if you use one <code>//~ ERROR</code>, you also need to annotate all warnings. I did not change that. I only changed that if you use zero annotations, you need to annotate errors and warnings</p>



<a name="148633803"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/borrowck-feature-nll-overrides-migrate%20test%20is%20wrong%3F/near/148633803" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/borrowck-feature-nll-overrides-migrate.20test.20is.20wrong.3F.html#148633803">(Nov 27 2018 at 12:07)</a>:</h4>
<p>... so, wait, how is that different from making <code>//~ ERROR</code> always mandatory?</p>



<a name="148633809"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/borrowck-feature-nll-overrides-migrate%20test%20is%20wrong%3F/near/148633809" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/borrowck-feature-nll-overrides-migrate.20test.20is.20wrong.3F.html#148633809">(Nov 27 2018 at 12:07)</a>:</h4>
<p>I guess if there is a <code>//~ WARN</code> annotation, then the <code>//~ ERROR</code> ones are not mandatory...?</p>



<a name="148633813"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/borrowck-feature-nll-overrides-migrate%20test%20is%20wrong%3F/near/148633813" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> oli <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/borrowck-feature-nll-overrides-migrate.20test.20is.20wrong.3F.html#148633813">(Nov 27 2018 at 12:07)</a>:</h4>
<p>no, warn and error is always mandatory now</p>



<a name="148633814"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/borrowck-feature-nll-overrides-migrate%20test%20is%20wrong%3F/near/148633814" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> oli <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/borrowck-feature-nll-overrides-migrate.20test.20is.20wrong.3F.html#148633814">(Nov 27 2018 at 12:07)</a>:</h4>
<p>no distinction</p>



<a name="148633815"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/borrowck-feature-nll-overrides-migrate%20test%20is%20wrong%3F/near/148633815" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/borrowck-feature-nll-overrides-migrate.20test.20is.20wrong.3F.html#148633815">(Nov 27 2018 at 12:07)</a>:</h4>
<p>oh okay great</p>



<a name="148633820"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/borrowck-feature-nll-overrides-migrate%20test%20is%20wrong%3F/near/148633820" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/borrowck-feature-nll-overrides-migrate.20test.20is.20wrong.3F.html#148633820">(Nov 27 2018 at 12:07)</a>:</h4>
<p>can you point me to PR and/or issue number?</p>



<a name="148633862"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/borrowck-feature-nll-overrides-migrate%20test%20is%20wrong%3F/near/148633862" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> oli <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/borrowck-feature-nll-overrides-migrate.20test.20is.20wrong.3F.html#148633862">(Nov 27 2018 at 12:08)</a>:</h4>
<p><a href="https://github.com/rust-lang/rust/pull/56244" target="_blank" title="https://github.com/rust-lang/rust/pull/56244">https://github.com/rust-lang/rust/pull/56244</a></p>



<a name="148633865"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/borrowck-feature-nll-overrides-migrate%20test%20is%20wrong%3F/near/148633865" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/borrowck-feature-nll-overrides-migrate.20test.20is.20wrong.3F.html#148633865">(Nov 27 2018 at 12:08)</a>:</h4>
<p>thx</p>



<hr><p>Last updated: Aug 07 2021 at 22:04 UTC</p>
</html>